1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109 | /**************************************************************************/
/* interpolated_property.h */
/**************************************************************************/
/* This file is part of: */
/* GODOT ENGINE */
/* https://godotengine.org */
/**************************************************************************/
/* Copyright (c) 2014-present Godot Engine contributors (see AUTHORS.md). */
/* Copyright (c) 2007-2014 Juan Linietsky, Ariel Manzur. */
/* */
/* Permission is hereby granted, free of charge, to any person obtaining */
/* a copy of this software and associated documentation files (the */
/* "Software"), to deal in the Software without restriction, including */
/* without limitation the rights to use, copy, modify, merge, publish, */
/* distribute, sublicense, and/or sell copies of the Software, and to */
/* permit persons to whom the Software is furnished to do so, subject to */
/* the following conditions: */
/* */
/* The above copyright notice and this permission notice shall be */
/* included in all copies or substantial portions of the Software. */
/* */
/* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, */
/* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF */
/* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. */
/* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY */
/* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, */
/* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE */
/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
/**************************************************************************/
#ifndef INTERPOLATED_PROPERTY_H
#define INTERPOLATED_PROPERTY_H
struct Vector2;
namespace InterpolatedPropertyFuncs {
float lerp(float p_a, float p_b, float p_fraction);
Vector2 lerp(const Vector2 &p_a, const Vector2 &p_b, float p_fraction);
} //namespace InterpolatedPropertyFuncs
// This class is intended to reduce the boiler plate involved to
// support custom properties to be physics interpolated.
template <class T>
class InterpolatedProperty {
// Only needs interpolating / updating the servers when
// curr and prev are different.
bool _needs_interpolating = false;
T _interpolated;
T curr;
T prev;
public:
// FTI depends on the constant flow between current values
// (on the current tick) and stored previous values (on the previous tick).
// These should be updated both on each tick, and also on resets.
void pump() {
prev = curr;
_needs_interpolating = false;
}
void reset() { pump(); }
void set_interpolated_value(const T &p_val) {
_interpolated = p_val;
}
const T &interpolated() const { return _interpolated; }
bool needs_interpolating() const { return _needs_interpolating; }
bool interpolate(float p_interpolation_fraction) {
if (_needs_interpolating) {
_interpolated = InterpolatedPropertyFuncs::lerp(prev, curr, p_interpolation_fraction);
return true;
}
return false;
}
operator T() const {
return curr;
}
bool operator==(const T &p_o) const {
return p_o == curr;
}
bool operator!=(const T &p_o) const {
return p_o != curr;
}
InterpolatedProperty &operator=(T p_val) {
curr = p_val;
_interpolated = p_val;
_needs_interpolating = true;
return *this;
}
InterpolatedProperty(T p_val) {<--- Class 'InterpolatedProperty' has a constructor with 1 argument that is not explicit. [+]Class 'InterpolatedProperty' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
curr = p_val;<--- Variable 'curr' is assigned in constructor body. Consider performing initialization in initialization list. [+]When an object of a class is created, the constructors of all member variables are called consecutively in the order the variables are declared, even if you don't explicitly write them to the initialization list. You could avoid assigning 'curr' a value by passing the value to the constructor in the initialization list.
_interpolated = p_val;<--- Variable '_interpolated' is assigned in constructor body. Consider performing initialization in initialization list. [+]When an object of a class is created, the constructors of all member variables are called consecutively in the order the variables are declared, even if you don't explicitly write them to the initialization list. You could avoid assigning '_interpolated' a value by passing the value to the constructor in the initialization list.
pump();
}
InterpolatedProperty() {
// Ensure either the constructor is run,
// or the memory is zeroed if using a fundamental type.
_interpolated = T{};<--- Variable '_interpolated' is assigned in constructor body. Consider performing initialization in initialization list. [+]When an object of a class is created, the constructors of all member variables are called consecutively in the order the variables are declared, even if you don't explicitly write them to the initialization list. You could avoid assigning '_interpolated' a value by passing the value to the constructor in the initialization list.
curr = T{};<--- Variable 'curr' is assigned in constructor body. Consider performing initialization in initialization list. [+]When an object of a class is created, the constructors of all member variables are called consecutively in the order the variables are declared, even if you don't explicitly write them to the initialization list. You could avoid assigning 'curr' a value by passing the value to the constructor in the initialization list.
prev = T{};<--- Variable 'prev' is assigned in constructor body. Consider performing initialization in initialization list. [+]When an object of a class is created, the constructors of all member variables are called consecutively in the order the variables are declared, even if you don't explicitly write them to the initialization list. You could avoid assigning 'prev' a value by passing the value to the constructor in the initialization list.
}
};
#endif // INTERPOLATED_PROPERTY_H
|